这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@james-d-elliott
Copy link
Member

No description provided.

@james-d-elliott james-d-elliott requested a review from a team as a code owner October 25, 2025 02:36
Copilot AI review requested due to automatic review settings October 25, 2025 02:36
@coderabbitai
Copy link

coderabbitai bot commented Oct 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a new CITATION.cff metadata file for the Go WebAuthn library project and updates the LICENSE file to reflect current copyright ownership by github.com/go-webauthn/webauthn authors with 2025 date.

Changes

Cohort / File(s) Summary
Citation metadata
CITATION.cff
New Citation File Format configuration specifying project version 0.14.0, license (BSD-3-Clause), abstract, authors with ORCID, keywords (webauthn, passkeys, cryptography), and repository details.
License update
LICENSE
Copyright line changed from 2017 Duo Security, Inc. to 2025 github.com/go-webauthn/webauthn authors; prior copyright and redistribution clauses from 2021-2022 removed, retaining final BSD-3-Clause disclaimer.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • CITATION.cff: Verify metadata fields are accurate and follow CFF specification
  • LICENSE: Confirm copyright year and entity attribution are correct and comply with BSD-3-Clause requirements

Poem

🐰 A citation spring forth, with metadata bright,
New copyright claims see the light,
From Duo's old days to a collective new way,
The WebAuthn legacy continues its play! 🔐

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docs-citation

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5dc4c56 and 7285da6.

📒 Files selected for processing (2)
  • CITATION.cff (1 hunks)
  • LICENSE (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@james-d-elliott james-d-elliott merged commit 4487237 into master Oct 25, 2025
8 of 9 checks passed
@james-d-elliott james-d-elliott deleted the docs-citation branch October 25, 2025 02:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project's licensing and citation metadata by consolidating copyright holders and adding a formal CITATION.cff file for academic references.

  • Consolidated dual copyright notices into a single 2025 copyright attribution
  • Added CITATION.cff file with comprehensive metadata for citing the library

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
LICENSE Updated copyright from dual attribution (Duo Security 2017 & go-webauthn 2021-2022) to single 2025 go-webauthn authors attribution
CITATION.cff Added new citation metadata file with library details, author information, and citation guidelines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- family-names: Elliott
given-names: James
orcid: 'https://orcid.org/0009-0000-4673-5510'
date-released: '2017-10-27'
Copy link

Copilot AI Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release date '2017-10-27' is inconsistent with the copyright year '2025' in the LICENSE file. If this represents the original project inception, consider adding a comment or adjusting to reflect the actual initial release date of this fork/version.

Suggested change
date-released: '2017-10-27'
# Original project inception: 2017-10-27
date-released: '2025-09-01'

Copilot uses AI. Check for mistakes.
- golang
repository-code: 'https://github.com/go-webauthn/webauthn/'
type: software
message: 'Available at https://github.com/go-webauthn/webauthn. v0.14.0 Accessed Sept, 2025.'
Copy link

Copilot AI Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abbreviated month 'Sept' should be 'Sep' following standard citation format conventions.

Suggested change
message: 'Available at https://github.com/go-webauthn/webauthn. v0.14.0 Accessed Sept, 2025.'
message: 'Available at https://github.com/go-webauthn/webauthn. v0.14.0 Accessed Sep, 2025.'

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.95%. Comparing base (2524fc4) to head (7285da6).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
- Coverage   44.97%   44.95%   -0.02%     
==========================================
  Files          37       37              
  Lines        3331     2449     -882     
==========================================
- Hits         1498     1101     -397     
+ Misses       1628     1143     -485     
  Partials      205      205              

see 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai coderabbitai bot mentioned this pull request Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants