OpenBSD build fix proposal #970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #970 +/- ##
===========================================
- Coverage 77.46% 75.81% -1.66%
===========================================
Files 74 74
Lines 8313 8082 -231
Branches 1374 1343 -31
===========================================
- Hits 6440 6127 -313
- Misses 1339 1425 +86
+ Partials 534 530 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mtl1979
reviewed
May 21, 2021
zutil.h
Outdated
| # if defined(__OpenBSD__) | ||
| # define ZSWAP16(q) __builtin_bswap16(q) | ||
| # define ZSWAP32(q) __builtin_bswap32(q) | ||
| # define ZSWAP64(q) __builtin_bswap64(q) |
Collaborator
There was a problem hiding this comment.
These should be swap16, swap32 and swap64 according to OpenBSD headers... We should not use compiler builtins if functions exist in standard headers. Might warrant separating OpenBSD as own #elif block.
Contributor
Author
There was a problem hiding this comment.
Yes there are but tried to use intrinsics rather than the macros (might be slower) but nevermind I ll change.
Collaborator
There was a problem hiding this comment.
At least gcc should map the functions in the standard headers automatically to the intrinsics when optimizations are enabled.
3d59315 to
bad3bf6
Compare
mtl1979
approved these changes
May 21, 2021
Dead2
added a commit
that referenced
this pull request
Jun 11, 2021
- Minor code cleanup #983 #984 - Fix mpicc compilation #959 - Fix build on NetBSD #964 - Fix build on OpenBSD #970 - Fix build on Cygwin #972 #974 - Fix linter warnings in configure #975 - Spelling fixes #961 - Improve unistd.h handling #960 - Remove stdarg.h detection #976 - CI/Test improvements #977 #981 #985 - Cmake improvements #980
Dead2
added a commit
that referenced
this pull request
Jun 11, 2021
- Minor code cleanup #983 #984 - Fix mpicc compilation #959 - Fix build on NetBSD #964 - Fix build on OpenBSD #970 - Fix build on Cygwin #972 #974 - Fix linter warnings in configure #975 - Spelling fixes #961 - Improve unistd.h handling #960 - Remove stdarg.h detection #976 - CI/Test improvements #977 #981 #985 - Cmake improvements #980 #989
Dead2
added a commit
that referenced
this pull request
Jun 11, 2021
- Fix inflate corruption #982 - Minor code cleanup #983 #984 - Fix mpicc compilation #959 - Fix build on NetBSD #964 - Fix build on OpenBSD #970 - Fix build on Cygwin #972 #974 - Fix linter warnings in configure #975 - Spelling fixes #961 - Improve unistd.h handling #960 - Remove stdarg.h detection #976 - CI/Test improvements #977 #981 #985 - Cmake improvements #980 #989
Merged
Dead2
added a commit
that referenced
this pull request
Jun 11, 2021
- Fix inflate corruption #982 - Minor code cleanup #983 #984 - Fix mpicc compilation #959 - Fix build on NetBSD #964 - Fix build on OpenBSD #970 - Fix build on Cygwin #972 #974 - Fix linter warnings in configure #975 - Spelling fixes #961 - Improve unistd.h handling #960 - Remove stdarg.h detection #976 - CI/Test improvements #977 #981 #985 - Cmake improvements #980 #989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.