这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix pointer type mismatch. #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2025
Merged

Fix pointer type mismatch. #1897

merged 1 commit into from
Apr 6, 2025

Conversation

@mtl1979
Copy link
Collaborator

@mtl1979 mtl1979 commented Apr 4, 2025 •
edited by coderabbitai bot
Loading

  • When passing pointer as function parameter, we need to make sure the underlying type is exact match.

Summary by CodeRabbit

  • Refactor
    • Enhanced internal handling of compression and decompression operations to support larger data sizes, which helps ensure robustness and scalability for demanding use cases.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 4, 2025 •
edited
Loading

Walkthrough

This update modifies the variable types for compressed_size and out_size in the uncompress_bench class within the benchmark file. The types have been changed from uLong to z_uintmax_t in both the SetUp and Bench methods. The logic for value assignment and error handling remains unchanged.

Changes

File(s) Change Summary
test/bench.../benchmark_uncompress.cc Updated variable types in uncompress_bench: changed uLong compressed_size and uLong out_size to z_uintmax_t compressed_size and z_uintmax_t out_size respectively.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 724dc0c and d244e4e.

📒 Files selected for processing (1)
  • test/benchmarks/benchmark_uncompress.cc (2 hunks)
🔇 Additional comments (2)
test/benchmarks/benchmark_uncompress.cc (2)

54-54: Type mismatch fix for compress interface.

The change from uLong to z_uintmax_t for compressed_size aligns the variable type with what's expected by the compress function pointer parameter. This addresses the pointer type mismatch mentioned in the PR description.

71-71: Type mismatch fix for uncompress interface.

The change from uLong to z_uintmax_t for out_size correctly aligns the variable type with what's expected by the uncompress function pointer parameter. This is consistent with the PR's objective to fix pointer type mismatches.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Apr 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.35%. Comparing base (724dc0c) to head (d244e4e).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1897      +/-   ##
===========================================
+ Coverage    82.85%   83.35%   +0.49%     
===========================================
  Files          144      144              
  Lines        12946    12950       +4     
  Branches      2855     2858       +3     
===========================================
+ Hits         10727    10795      +68     
+ Misses        1248     1208      -40     
+ Partials       971      947      -24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtl1979 mtl1979 marked this pull request as ready for review April 4, 2025 19:18
Dead2
Dead2 approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dead2 Dead2 merged commit e88471f into zlib-ng:develop Apr 6, 2025
148 of 153 checks passed
@Dead2 Dead2 mentioned this pull request Aug 3, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Sep 6, 2025
Merged
This was referenced Oct 6, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmoinvaz nmoinvaz nmoinvaz approved these changes

@Dead2 Dead2 Dead2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtl1979 @nmoinvaz @Dead2