这是indexloc提供的服务，不要输入任何密码
Skip to content

Remove unused HAVE_CHUNKMEMSET_1 define #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2024
Merged

Remove unused HAVE_CHUNKMEMSET_1 define #1815

merged 1 commit into from
Dec 1, 2024

Conversation

@pps83
Copy link
Contributor

@pps83 pps83 commented Nov 27, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Support for chunk memory setting has been streamlined by removing 1-byte chunk operations, enhancing the focus on larger chunk sizes (2, 4, 8, and 16 bytes).

  • Bug Fixes

    • Removed deprecated functionality for 1-byte chunk memory setting to improve overall performance and reliability.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2024 •
edited
Loading

Walkthrough

The pull request involves the removal of the HAVE_CHUNKMEMSET_1 macro definition from two files: chunkset_avx2.c and chunkset_avx512.c. This change signifies that the functionality for handling 1-byte chunk memory setting is no longer supported. Consequently, the chunkmemset_1 function is eliminated, while functions for larger chunk sizes remain intact. The overall structure of both files is preserved, with no new functions introduced or existing functions modified beyond this removal.

Changes

File Path Change Summary
arch/x86/chunkset_avx2.c Removed definition of HAVE_CHUNKMEMSET_1.
arch/x86/chunkset_avx512.c Removed definition of HAVE_CHUNKMEMSET_1.

Possibly related PRs

  • Improve chunkset_avx2 performance #1778: The changes in this PR also involve the removal of support for 1-byte chunk memory setting, specifically in the context of chunkset_avx2.c, which aligns with the main PR's removal of HAVE_CHUNKMEMSET_1 in the same file.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0ed5ac8 and 735fb0f.

📒 Files selected for processing (2)
  • arch/x86/chunkset_avx2.c (0 hunks)
  • arch/x86/chunkset_avx512.c (0 hunks)
💤 Files with no reviewable changes (2)
  • arch/x86/chunkset_avx2.c
  • arch/x86/chunkset_avx512.c

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.17%. Comparing base (0ed5ac8) to head (735fb0f).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1815      +/-   ##
===========================================
- Coverage    32.18%   32.17%   -0.01%     
===========================================
  Files           67       67              
  Lines         5752     5753       +1     
  Branches      1237     1237              
===========================================
  Hits          1851     1851              
- Misses        3644     3651       +7     
+ Partials       257      251       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Dead2
Dead2 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dead2 Dead2 merged commit 3c11f65 into zlib-ng:develop Dec 1, 2024
142 of 150 checks passed
@pps83 pps83 deleted the develop-rm-memset1 branch December 2, 2024 14:23
@Dead2 Dead2 mentioned this pull request Dec 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dead2 Dead2 Dead2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pps83 @Dead2