这是indexloc提供的服务，不要输入任何密码
Skip to content

configure: add --mandir to override $mandir on command line. #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

configure: add --mandir to override $mandir on command line. #1800

merged 1 commit into from
Oct 10, 2024

Conversation

@mtl1979
Copy link
Collaborator

@mtl1979 mtl1979 commented Sep 28, 2024 •
edited by coderabbitai bot
Loading

On some platforms like Haiku the file layout is different than on Linux and *BSD... This allows fixing the layout with single command.

NOTES:

  1. In Haiku, building cmake requires libz (zlib), which create circular dependency when using cmake to build libz.
  2. There is existing package to build zlib-ng 2.2.2 using cmake.

Summary by CodeRabbit

  • New Features

    • Introduced a new --mandir=MANDIR option in the usage instructions for enhanced manual page directory configuration.

  • Bug Fixes

    • Updated argument parsing to correctly recognize and handle the new --mandir option.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 28, 2024 •
edited
Loading

Walkthrough

The changes in this pull request involve modifications to the configure script, specifically enhancing the usage instructions and argument parsing. The --mandir=MANDIR option has been added to the usage message, allowing users to specify a directory for manual pages. The script's argument parsing has also been updated to recognize this new option, enabling it to capture and assign the provided value to a designated variable.

Changes

File(s) Change Summary
configure Added --mandir=MANDIR option to usage instructions; updated argument parsing to handle --mandir.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ConfigureScript

    User->>ConfigureScript: run configure --mandir=/path/to/mandir
    ConfigureScript->>ConfigureScript: parse arguments
    ConfigureScript->>ConfigureScript: set mandir variable to /path/to/mandir
    ConfigureScript-->>User: configuration complete
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Sep 28, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
configure (1)

Line range hint 1-1188: Consider initializing mandir variable with a default value

While the implementation of the --mandir option is correct, it would be beneficial to initialize the mandir variable with a default value earlier in the script, similar to how other configuration variables are handled. This ensures that mandir always has a value, even if the --mandir option is not used.

Consider adding a line like this near the other variable initializations (around line 80-90):

mandir=${mandir-'${prefix}/share/man'}

This sets a default value while still allowing it to be overridden by environment variables or command-line options.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8d10c30 and 00ec57a.

📒 Files selected for processing (1)
  • configure (2 hunks)
🔇 Additional comments (2)
configure (2)

162-162: LGTM: Usage instructions updated correctly

The new --mandir=MANDIR option has been properly added to the usage instructions. The formatting is consistent with other options, making it clear and easy to understand for users.

188-188: LGTM: Argument parsing for --mandir implemented correctly

The new case for handling the --mandir argument is implemented correctly. It extracts the value after the = sign and assigns it to the mandir variable, consistent with how other similar options are handled in the script.

@Dead2 Dead2 merged commit 1ec47b7 into zlib-ng:develop Oct 10, 2024
@Dead2 Dead2 mentioned this pull request Dec 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Dead2 Dead2 Dead2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtl1979 @Dead2