这是indexloc提供的服务，不要输入任何密码
Skip to content

added in-tree build artifacts to .gitignore #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024
Merged

added in-tree build artifacts to .gitignore #1823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
/switchlevels
/zlib.pc
/zlib-ng.pc
/zconf-ng.h.included
/zlib_name_mangling-ng.h
/zlib-ng.h

.DS_Store
*_fuzzer
Expand Down Expand Up @@ -61,6 +64,7 @@ zconf-ng.h.cmakein
ztest*
/test/CTestTestfile.cmake
/test/cmake_install.cmake
/.cache

configure.log
a.out
Expand All @@ -72,6 +76,10 @@ a.out
/arch/x86/Makefile
.kdev4
*.kdev4
Makefile.tmp
/makecrct
/maketrees
gzread.c
Comment on lines +79 to +82
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Based on the build system analysis, I can now provide a final response:

Additional build artifacts need to be ignored

The project uses both CMake and Configure build systems. The current .gitignore is missing several common build artifacts:

  • CMake build artifacts:
    • CMakeFiles/
    • CMakeCache.txt
    • cmake_install.cmake
    • CPackConfig.cmake
    • CPackSourceConfig.cmake
    • *.a
    • *.so*
    • *.dll
    • *.dylib
  • Build outputs:
    • minigzip
    • minideflate
    • libz.*
    • zlib.pc
  • Test artifacts:
    • test/example
    • test/minigzip
    • test/gtest_zlib

These patterns should be added to ensure all build artifacts are properly ignored.

🔗 Analysis chain

Verify coverage of in-tree build artifacts

Let's ensure we haven't missed any common build artifacts.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for typical configure/make artifacts in the repository
# that might not be covered by current patterns

# Look for configure-generated files
fd -H -E .git "config\.(log|status|cache)" 

# Look for make-generated files
fd -H -E .git "\.deps$|\.libs$|\.dirstamp$"

# Look for common object file patterns not covered
fd -H -E .git "\.(la|lai|lo|o|so|so\.[0-9]+)$"

Length of output: 139

Script:

#!/bin/bash
# Let's check the build system and potential artifacts by:
# 1. Looking for build-related files to understand the build system
# 2. Checking for patterns of generated files in build instructions

# Check for build system files
fd -H -E .git "configure\.ac|configure\.in|Makefile\.am|Makefile\.in|CMakeLists\.txt|\.cmake$"

# Look at build instructions in documentation
if [ -f "README.md" ]; then
    echo "=== README.md ==="
    cat README.md | grep -A 5 -i "build\|compile\|make"
fi

if [ -f "INSTALL" ]; then
    echo "=== INSTALL ==="
    cat INSTALL | grep -A 5 -i "build\|compile\|make"
fi

# Check for any existing make targets
if [ -f "Makefile" ]; then
    echo "=== Makefile targets ==="
    grep "^[a-zA-Z0-9_-]*:" Makefile
fi

Length of output: 13362


/Debug
/example.dir
Expand Down
Loading