Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.90%. Comparing base (a32e1eb) to head (ebb237e).

@@             Coverage Diff             @@
##           develop    #1736      +/-   ##
===========================================
- Coverage    82.90%   82.90%   -0.01%     
===========================================
  Files          136      136              
  Lines        10280    10281       +1     
  Branches      2797     2798       +1     
===========================================
  Hits          8523     8523              
  Misses        1060     1060              
- Partials       697      698       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Of course this is now triggered by -Wzero-as-null-pointer-constant (enabled for C in GCC 15, not enabled by either of Wall or Wextra... yet).

src/http/modules/ngx_http_gunzip_filter_module.c:307:26: error: zero as null pointer constant [-Werror=zero-as-null-pointer-constant]
  307 |     ctx->zstream.next_in = Z_NULL;
      |                          ^

zlib also declare Z_NULL macro as 0:

https://github.com/madler/zlib/blob/5a82f71ed1dfc0bec044d9702463dbdf84ea3b71/zlib.h#L216

This macro is only for compatibility with zlib.

Use NULL instead of Z_NULL.

I'm thinking of the case where you have a code base that was developed against zlib but may now build with either zlib or zlib-ng-comat as Linux distributions are now switching to...

No biggie... just an unfortunate legacy decision...

This change was made because defining the Z_NULL macro as NULL broke other legacy code bases :(

There is no reason to use the Z_NULL macro in the code now. This is zlib-compatibility macro.