CMake: Replace ; by $<SEMICOLON> in generator-expression
#1707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: CMake generator-expressions should not contain semicolons, especially if they might end up in a CMake list, because a semicolon would be interpreted as list-item separator and therefore render the generator-expression invalid. The generator-expression `$<SEMICOLON>` should be used instead. Signed-off-by: Deniz Bahadir <deniz@code.bahadir.email>
Member
|
Looks ok to me |
nmoinvaz
approved these changes
Apr 10, 2024
Dead2
approved these changes
Apr 10, 2024
mtl1979
approved these changes
Apr 11, 2024
This was referenced May 30, 2024
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake generator-expressions should not contain semicolons, especially if they might end up in a CMake list, because a semicolon (
;) would be interpreted as list-item separator and therefore render the generator-expression invalid. The generator-expression$<SEMICOLON>should be used instead.