这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Dead2
Copy link
Member

@Dead2 Dead2 commented Feb 21, 2024

These files are useless outside of git and github, so don't distribute them to users downloading/exporting tar.gz, zip or other archives. Doing this is relatively common for well-known projects.

@Dead2 Dead2 added the cleanup Improving maintainability or removing code. label Feb 21, 2024
Copy link
Collaborator

@mtl1979 mtl1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca0e463) 83.01% compared to head (c8b79d9) 83.01%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1688   +/-   ##
========================================
  Coverage    83.01%   83.01%           
========================================
  Files          135      135           
  Lines        10365    10365           
  Branches      2815     2815           
========================================
  Hits          8605     8605           
+ Misses        1067     1063    -4     
- Partials       693      697    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dead2 Dead2 merged commit 990ebb6 into develop Feb 22, 2024
This was referenced May 30, 2024
@Dead2 Dead2 mentioned this pull request Jun 12, 2024
@Dead2 Dead2 deleted the gitarchive_ignore_gitfiles branch July 2, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Improving maintainability or removing code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants