这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@mtl1979
Copy link
Collaborator

@mtl1979 mtl1979 commented Feb 19, 2024

  • Remove trailing comma from list of CodeCov artifacts to avoid warning and subsequent error state.

run: |
python3 -u -m pip install --user gcovr==5.0
python3 -m gcovr -j 3 --verbose \
python3 -m gcovr ${{ matrix.build-dir || '' }} -j 3 --verbose \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? I thought that is the purpose of the --root arg below.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For out-of-source builds, the build/binary directory needs to be sub-directory of the source directory for --root argument to work, it's limitation of filtering in gcovr... However it is possible to pass binary directory separately without that restriction.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was out of source builds previously working fine?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why but recently I noticed that the size of coverity artifact dropped from few tens of kilobytes on normal builds to about 300 bytes on OSB builds. It was pretty clear hint that no coverity data was found or collected.

@Dead2 Dead2 merged commit 619f6c9 into zlib-ng:develop Mar 3, 2024
This was referenced May 30, 2024
@Dead2 Dead2 mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants