Prevent tests writing into the source directory #1604
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1604 +/- ##
===========================================
+ Coverage 83.26% 83.27% +0.01%
===========================================
Files 133 133
Lines 10879 10879
Branches 2809 2809
===========================================
+ Hits 9058 9060 +2
+ Misses 1117 1116 -1
+ Partials 704 703 -1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
We require cmake 3.5.1 or later, so any features that require newer cmake version -- without fallback -- can't be used. Several CI tests need to be rerun as either them failed (for unknown reason) or were skipped due to other checks failing. |
Fallback - do not build zlib-ng with the source directory in read-only mode (anyway it's impossible now).
It seems I don't have permission to restart CI. |
|
CI error:
|
|
|
||
| set(INPUT_FILE ${OUTPUT_BASE}) | ||
|
|
||
| # Make CMake copy and rename file in one operation |
There was a problem hiding this comment.
This comment is missing info and is a little misleading.
There was a problem hiding this comment.
I haven't changed this comment.
Or do I need to move it before configure_file?
There was a problem hiding this comment.
You changed the content that the comment describes, so the comment should be updated to describe the new situation.
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Sometimes it's hard to decide if two related changes should be in same or separate pull requests. In this case there is no controversy in improving how a test is executed, but we already require that source directory is writable, so requiring that it is not written to is backwards. |
Unit test #1603 creates a file in the source directory.