Clean up SSE4.2 support #1542
Merged
Clean up SSE4.2 support #1542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines changing meaning: X86_SSE42 used to mean the compiler supports crc asm fallback. X86_SSE42_CRC_INTRIN used to mean compiler supports SSE4.2 intrinsics. X86_SSE42 now means compiler supports SSE4.2 intrinsics. This therefore also fixes the adler32_sse42 checks, since those were depending on SSE4.2 intrinsics but was mistakenly checking the X86_SSE42 define. Now the X86_SSE42 define actually means what it appears to.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1542 +/- ##
===========================================
+ Coverage 83.89% 83.91% +0.01%
===========================================
Files 132 132
Lines 10850 10850
Branches 2794 2796 +2
===========================================
+ Hits 9103 9105 +2
+ Misses 1048 1047 -1
+ Partials 699 698 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Contributor
|
Ah cool, looks like you got to the bottom of the real issue |
Member
Author
|
This passes all tests, just waiting for reviews. |
Contributor
|
LGTM |
KungFuJesus
approved these changes
Jul 24, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up SSE4.2 support, and no longer use asm fallback or gcc builtin.
Defines changing meaning:
X86_SSE42used to mean the compiler supports crc asm fallback.X86_SSE42_CRC_INTRINused to mean compiler supports SSE4.2 intrinsics.X86_SSE42now means compiler supports SSE4.2 intrinsics.This therefore also fixes the adler32_sse42 checks, since those wanted to check for SSE4.2 intrinsics but were mistakenly checking for crc asm fallback support. Now the
X86_SSE42define actually means what it appears to.Also contains the commit to move check_c_source_compile_or_run macro to the script where it gets used, only semi-related to the rest of this PR.
Fixes #1529