frontend/src/components/common/GuestRoute.tsx (1)

18-22: Optional: centralize all “where to go” logic behind WorkspaceRedirectHandler

If lastWorkspaceSlug becomes stale (user removed from that workspace), navigating directly to /${slug} could yield a 404 before any fallback. Consider always sending guests to /workspace and letting the centralized redirect handler decide the target. This trades one extra redirect for more robust behavior in edge cases.

Example change:

-    const redirectPath = userStore.data?.lastWorkspaceSlug
-      ? `/${userStore.data.lastWorkspaceSlug}`
-      : "/workspace";
-
-    return <Navigate to={redirectPath} state={{ from: location }} replace />;
+    return <Navigate to="/workspace" state={{ from: location }} replace />;

backend/src/users/dto/update-last-workspace-slug.dto.ts (1)

1-8: ValidationPipe Transform Confirmed

Global ValidationPipe is configured with { transform: true } in backend/src/main.ts:22, so the @Transform decorator will run as expected.

You can safely apply the following enhancements to UpdateLastWorkspaceSlugDto to tighten validation and normalize the workspace slug:

--- a/backend/src/users/dto/update-last-workspace-slug.dto.ts
+++ b/backend/src/users/dto/update-last-workspace-slug.dto.ts
@@
-import { ApiProperty } from "@nestjs/swagger";
-import { IsString } from "class-validator";
+import { ApiProperty } from "@nestjs/swagger";
+import { IsString, IsNotEmpty, Matches, MaxLength } from "class-validator";
+import { Transform } from "class-transformer";

 export class UpdateLastWorkspaceSlugDto {
   @ApiProperty({ type: String, description: "Workspace slug to set as last accessed" })
-  @IsString()
-  workspaceSlug: string;
+  @IsString()
+  @IsNotEmpty()
+  @MaxLength(64)
+  @Matches(/^[a-z0-9](?:[a-z0-9-]*[a-z0-9])?$/, { message: "Invalid slug format" })
+  @Transform(({ value }) => String(value).trim().toLowerCase())
+  workspaceSlug: string;
 }

• Imports updated to include IsNotEmpty, MaxLength, Matches, and Transform.
• Enforces non-empty, max-length (64), and a canonical slug pattern.
• Normalizes incoming values by trimming whitespace and lowercasing.

These changes will prevent silent mismatches in routing and comparisons.

frontend/src/hooks/api/user.ts (1)

112-130: Guard against empty input and avoid sending whitespace-only slugs

A small guard + trim prevents no-op/invalid writes and reduces noise on the backend. Also keeps typing as void consistently returned.

 export const useUpdateLastWorkspaceSlugMutation = () => {
   const authStore = useSelector(selectAuth);
   const queryClient = useQueryClient();
 
   return useMutation({
-    mutationFn: async (workspaceSlug: string) => {
-      const res = await axios.patch<void>("/users/last-workspace-slug", {
-        workspaceSlug,
-      });
-
-      return res.data;
-    },
+    mutationFn: async (workspaceSlug: string) => {
+      const ws = workspaceSlug?.trim();
+      if (!ws) {
+        return;
+      }
+      const res = await axios.patch<void>("/users/last-workspace-slug", { workspaceSlug: ws });
+      return res.data;
+    },
     onSuccess: () => {
       queryClient.invalidateQueries({
         queryKey: generateGetUserQueryKey(authStore.accessToken || ""),
       });
     },
   });
 };

Optional follow-up: consider short-circuiting server-side (don’t update if the value is unchanged) to eliminate redundant writes under frequent navigations.

frontend/src/hooks/api/workspace.ts (1)

45-45: Avoid redundant PATCH calls when the slug hasn’t changed

Only update the last-workspace slug if it differs from the one we already have for the user. This reduces unnecessary network chatter and DB writes.

-      updateLastWorkspaceSlug(query.data.slug).catch(() => {});
+      // Only persist when the value actually changes
+      if (userStore.data?.lastWorkspaceSlug !== query.data.slug) {
+        updateLastWorkspaceSlug(query.data.slug).catch(() => {});
+      }

-  }, [dispatch, query.data, updateLastWorkspaceSlug]);
+  }, [dispatch, query.data, updateLastWorkspaceSlug, userStore]);

Add the minimal wiring outside this hunk:

// Add imports
import { useSelector } from "react-redux";
import { selectUser } from "../../store/userSlice";

// Inside the hook (near dispatch)
const userStore = useSelector(selectUser);

Optional: instead of .catch(() => {}), report errors to your telemetry (Sentry, console.warn) so you can observe unexpected membership failures.

If you want, I can push a follow-up commit wiring these imports and dependencies.

Also applies to: 52-52

backend/src/users/users.service.ts (1)

15-29: Prefer findUniqueOrThrow here to avoid returning null for a typed FindUserResponse.

The signature promises FindUserResponse, but findUnique may yield null (e.g., stale token). Using findUniqueOrThrow produces a consistent 404 and a safer type.

Here’s a minimal refactor:

- const foundUser = await this.prismaService.user.findUnique({
+ const foundUser = await this.prismaService.user.findUniqueOrThrow({
   select: {
     id: true,
     nickname: true,
     lastWorkspaceSlug: true,
     createdAt: true,
     updatedAt: true,
   },
   where: { id: userId },
 });

If you intentionally want null → 200, please confirm so we can align the controller docs accordingly.

backend/src/users/users.controller.ts (1)

1-1: Import HttpCode/HttpStatus for proper 204 semantics on PATCH.

You’re returning void; better to signal “no content” explicitly.

-import { Body, Controller, Get, Put, Req, Patch } from "@nestjs/common";
+import { Body, Controller, Get, Put, Req, Patch, HttpCode, HttpStatus } from "@nestjs/common";

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

frontend/src/components/layouts/DocumentLayout.tsx (1)

13-17: Consider consolidating persistence logic.

Both DocumentLayout and WorkspaceLayout persist the workspace slug identically. While this ensures coverage, you could optionally consolidate this into a shared hook (e.g., useWorkspacePersistence) to reduce duplication.

frontend/src/hooks/api/user.ts (1)

45-72: Remove unnecessary dependency from interceptor effect.

The interceptor effect at line 72 now includes userStore.data?.id in its dependency array. Since the interceptor reads the current userStore.data?.id from the closure when errors occur, adding it to deps causes the interceptor to re-register whenever the user ID changes, which is unnecessary overhead.

Consider removing userStore.data?.id from the dependency array at line 72. The interceptor will still have access to the current user ID through the closure, and this avoids re-creating the interceptor when the user ID changes.

Alternatively, if you want to ensure the interceptor always has the latest user ID without relying on closure behavior, you could use a ref:

const userIdRef = useRef(userStore.data?.id);
useEffect(() => {
  userIdRef.current = userStore.data?.id;
}, [userStore.data?.id]);

Then reference userIdRef.current in the interceptor and remove userStore.data?.id from the interceptor effect's dependencies.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro