ci: build the sample resume in ci #2
Conversation
|
Thanks for your interest in this project, I guess this PR is try to set up an smoke test step for the CI pipeline just make resure that new commits won't break the real build, right? Let me know when this PR is ready to merge, before merge, please make resure that the commits is squashed into one (or I can do that for you, just want to avoid to make the git history too tedious). Thank you! |
|
@xiaohanyu Thank you for your amazing work! This PR is actually to make sure the latex setup on Ubuntu is reproducible. |
| @@ -0,0 +1,2 @@ | |||
| node_modules | |||
| compose.yml | |||
There was a problem hiding this comment.
OK just got time to review this PR.
So I would suggest we remove docker related files in this PR and instead making all docker related files in #5.
So .dockerignore, Dockerfile and compose.yml is not needed in this PR.
| - name: Install texlive-latex | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y texlive-latex-base texlive-xetex texlive-latex-extra texlive-fonts-recommended texlive-fonts-extra |
There was a problem hiding this comment.
- let us just use
aptinstead ofapt-getacross the whole github CI flow - the minimum requirements for texlive dependency:
sudo apt install -y texlive-xetex texlive-fonts-extra texlive-lang-all
|
|
||
| - name: Install fonts | ||
| run: | | ||
| sudo apt install fonts-linuxlibertine |
There was a problem hiding this comment.
I think we can remove apt install fonts-linuxlibertine here because linux libertine font is already included in texlive-fonts-extra
| run: | | ||
| sudo apt install fonts-linuxlibertine | ||
| sudo apt install fonts-noto-cjk fonts-noto-cjk-extra | ||
| sudo apt install latex-cjk-all |
There was a problem hiding this comment.
latex-cjk-all is included in texlive-lang-all package, so no need here.
I am planning to support more languages other than CJK, so let us just use texlive-lang-all.
| node packages/cli/dist/cli.js build packages/cli/resources/resume.yml | ||
| ls -lah | ||
| - name: Check files | ||
| if: always() |
| @@ -0,0 +1,12 @@ | |||
| FROM node:22-slim AS base | |||
There was a problem hiding this comment.
let us add Dockerfile in your second PR #5
| @@ -0,0 +1,5 @@ | |||
|
|
|||
There was a problem hiding this comment.
Same as above, move compose.yml to your second PR #5
| # - name: Setup TeX Live | ||
| # uses: teatimeguest/setup-texlive-action@v3 | ||
| # with: | ||
| # packages: scheme-basic |
There was a problem hiding this comment.
this part can be removed if not needed.
Co-author: [@xiaohanyu](xiaohanyu1988@gmail.com) Credit to [@jizusun](https://github.com/jizusun) for the first [PR](#2) for YAMLResume.
relates to #4