This repository was archived by the owner on Feb 8, 2019. It is now read-only.
Recurring events support #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 3, 2014 14:57
Contributor
|
Wow, this is actually amazing. But this will take a while for me to check it deeply. But will be done today. |
Contributor
Author
|
There's no rush to merge this if you're busy, we can run it in production for a while here and make sure there are no regressions (and if there are I'll add more tests). In the mean time any feedback is welcome, I appreciate its a bigger change. |
Contributor
|
I'm extremely glad to hear btw, that you're running the stuff in prod as well like we do. |
Contributor
|
wow, nice, had the time to review run it through finally. Thanks for your contrib as always. Merging it. |
Contributor
Author
|
Thanks, its worked well for us (after I fixed that silly bug!) - given us a lot more flexibility. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django-schedulerdoes support recurring events, this puts in some of the plumbing so we can start using them. I haven't added a UI for creating a custom rule, but have included fixtures for some basic ones and custom rules can be at least inserted into the database manually and they will work.