这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 8, 2019. It is now read-only.

Conversation

@DazWorrall
Copy link
Contributor

Grouped/Threaded conversations based on subject line make the current email alerts hard to follow - at least they do in GMail!

I hope you don't mind many small pull requests - I'm doing it this way so you can cherry pick the small changes I'm making to scratch some itches as I find them.

Darren Worrall added 2 commits October 29, 2014 11:02
Grouped/Threaded conversations based on subject line make the current
email alerts hard to follow - at least they do in GMail!
@deathowl
Copy link
Contributor

Good, but we could add description instead of ID, what do you think?

@DazWorrall
Copy link
Contributor Author

Our descriptions are generally short (they're from Icinga) so I have no problem with that. The description field limit is 100 chars though, should we truncate that in the email?

@DazWorrall
Copy link
Contributor Author

Actually its not that long - I'll just change it.

@DazWorrall
Copy link
Contributor Author

Ha, so it turns out our descriptions are being silently truncated (long hostnames again), so the 100 char limit may not be enough!

Ok, how about this: we increase the description character limit on the model, and truncate it to 100 characters in the email subject?

@deathowl
Copy link
Contributor

This works for me perfectly. If you have any ideas, we could talk about it on #openduty on Freenode.

@DazWorrall
Copy link
Contributor Author

Ok, changes pushed - made the truncation optional and tuneable. I'll keep IRC in mind, thanks!

deathowl added a commit that referenced this pull request Oct 29, 2014
@deathowl deathowl merged commit 2f1ed94 into ustream:master Oct 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants