Fix varinit on global const blocks #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The varinit linter would report errors against global const blocks where constants are defined with iota - in that case constants after iota would have no initializer. This commit skips global const blocks entirely, because - if iota is used, constants are indeed initialized - constants not covered by iota and without an initializer will not compile
Contributor
|
Thanks, this looks great! I guess that goes for all constants - you can't define constants without initializing so we don't need to check those in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
varinitlinter reports false negative results against global const blocks where constants are defined withiota- in that case constants afteriotawould have no initializer. This commit skips global const blocks entirely, becauseiotais used, constants are indeed initializediotaand without an initializer will not compile