Tasks signature #74
Merged
Tasks signature #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors method signatures across the Upsun SDK test suite and core files to use named parameters instead of positional arguments. The main goals are to improve code readability, type safety, and maintainability by explicitly naming parameters when calling methods.
- Replace array-based parameter passing with named parameters in task method calls
- Add proper PHPDoc annotations with
@throwsdeclarations for exception handling - Remove variable definitions where parameters are now passed directly as named arguments
Reviewed Changes
Copilot reviewed 47 out of 49 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/UpsunConfigTest.php | Updates constructor calls and test methods to use named parameters |
| tests/UpsunClientTest.php | Adds exception documentation and uses named parameters |
| tests/Core/Tasks/WorkersTaskTest.php | Refactors worker task method calls to use named parameters |
| tests/Core/Tasks/VariablesTaskTest.php | Converts variable task operations from array-based to named parameter calls |
| tests/Core/Tasks/UsersTaskTest.php | Updates user management operations with named parameters and adds new test methods |
| tests/Core/Tasks/TeamsTaskTest.php | Refactors team operations to use named parameters and adds new test cases |
| tests/Core/Tasks/SupportTicketsTaskTest.php | Updates support ticket operations with named parameters |
| tests/Core/Tasks/SourceOperationsTaskTest.php | Converts source operation calls to named parameters |
| tests/Core/Tasks/RoutesTaskTest.php | Updates route management calls with named parameters |
| tests/Core/Tasks/ResourcesTaskTest.php | New test file for resource management operations |
| tests/Core/Tasks/RegionsTaskTest.php | Updates region operations with named parameters |
| tests/Core/Tasks/ProjectsTaskTest.php | Extensive refactoring of project operations to use named parameters |
| tests/Core/Tasks/OrganizationsTaskTest.php | Updates organization management with named parameters and improved test data |
| tests/Core/Tasks/OperationsTaskTest.php | Refactors operation execution calls to use named parameters |
| tests/Core/Tasks/InvitationsTaskTest.php | Updates invitation management with named parameters |
| tests/Core/Tasks/BaseTestCase.php | Minor documentation improvement |
| templates/php/README.mustache | Updates README examples to use named parameters |
| src/UpsunClient.php | Updates constructor calls to use named parameters |
Comments suppressed due to low confidence (2)
tests/Core/Tasks/OperationsTaskTest.php:1
- The test method
testRunThrowsApiExceptionshould throw anApiExceptionbut instead creates a result and asserts equality. The method name indicates it should test exception throwing, but the implementation doesn't match.
<?php
tests/Core/Tasks/ProjectsTaskTest.php:1
- Assertion compares
$projectsarray with itself. This should likely compare$projectswith$orgProjectList['items']to validate the actual vs expected data.
<?php
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 47 out of 49 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.