这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix composer comment #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
Merged

Fix composer comment #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bdf9ee
remove _generator and _warning from composer.json
flovntp Nov 4, 2025
aebc2bc
add composer validate in develop
flovntp Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/develop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,13 @@ jobs:
php-version: ${{ env.PRIMARY_PHP_VERSION }}
tools: composer

- name: Validate dependency file
run: composer validate --strict

- name: Install dependencies
run: composer run install:ci

- name: Run PHP lint (phpcs, php-cs-fixer, rector)
- name: Run PHP lint (phpcs, php-cs-fixer, rector)
run: composer run lint:all

- name: symfony-insight
Expand All @@ -46,7 +49,7 @@ jobs:

strategy:
matrix:
php-version: [8.1, 8.2, 8.3, 8.4]
php-version: [8.1, 8.2, 8.3, 8.4]

steps:
- name: Checkout repository
Expand All @@ -64,20 +67,20 @@ jobs:

- name: Run unit tests
run: composer run test:unit

doc:
name: Generate Documentation
runs-on: ubuntu-latest
needs: [ tests ]

steps:
- name: Checkout repository
uses: actions/checkout@v4

- uses: ./.github/actions/doc
with:
default-runtime-version: ${{ env.PRIMARY_PHP_VERSION }}

coverage:
name: Code Coverage Report
runs-on: ubuntu-latest
Expand All @@ -96,7 +99,7 @@ jobs:
name: Build Project
runs-on: ubuntu-latest
needs: [ coverage, quality ]
# Deactivated as not necessary for PHP
# Deactivated as not necessary for PHP
if: false
steps:
- name: Checkout repository
Expand Down
4 changes: 1 addition & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
{
"_comment": "AUTO-GENERATED FILE - DO NOT EDIT",
"_generator": "Generated by OpenAPI Generator",
"_warning": "Manual changes will be overwritten, please update `templates/php/libraries/psr-18/composer.mustache` file and regenerate files",
"_comment": "AUTO-GENERATED FILE - DO NOT EDIT. Manual changes will be overwritten, please update `templates/php/libraries/psr-18/composer.mustache` file and regenerate files",
"name": "upsun/upsun-sdk-php",
"type": "library",
"description": "The official Upsun SDK for PHP",
Expand Down
4 changes: 1 addition & 3 deletions templates/php/libraries/psr-18/composer.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
{
"_comment": "AUTO-GENERATED FILE - DO NOT EDIT",
"_generator": "Generated by OpenAPI Generator",
"_warning": "Manual changes will be overwritten, please update `templates/php/libraries/psr-18/composer.mustache` file and regenerate files",
"_comment": "AUTO-GENERATED FILE - DO NOT EDIT. Manual changes will be overwritten, please update `templates/php/libraries/psr-18/composer.mustache` file and regenerate files",
{{#composerPackageName}}
"name": "{{{.}}}",
{{/composerPackageName}}
Expand Down