Remove phpunit.xml.dist and Fix generation of phpunit.xml #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the phpunit.xml.dist file and updates the PHPUnit configuration template and generated file to include additional configuration options. The changes standardize the PHPUnit configuration by consolidating it into a single template-based approach.
Key Changes:
- Removed
phpunit.xml.distconfiguration file - Enhanced PHPUnit configuration template with better formatting and additional attributes
- Updated generated
phpunit.xmlto match the new template structure
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| templates/php/phpunit.xml.mustache | Reformatted XML with better readability and added testsuites configuration section |
| phpunit.xml.dist | Removed distribution configuration file |
| phpunit.xml | Added error conversion attributes and php configuration section to match template |
Comments suppressed due to low confidence (1)
phpunit.xml:1
- Remove trailing whitespace after attribute values on lines 5 and 6.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dced4ae to
195a088
Compare
flovntp
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.