add UpsunClientTest, UpsunConfigTest and OAuthProviderTest #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for three core SDK classes: UpsunClient, UpsunConfig, and OAuthProvider. Additionally, it reorganizes the test suite by correcting namespace paths for all task-related test files.
- Introduces new test files for UpsunClient, UpsunConfig, and OAuthProvider classes with thorough coverage of their functionality
- Fixes namespace declarations across all task test files to follow proper directory structure
- Reorganizes import statements in task test files for better code organization
- Removes coverage logging configuration from phpunit.xml
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/UpsunConfigTest.php | New comprehensive test suite for UpsunConfig class covering constructor validation, property access, and configuration scenarios |
| tests/UpsunClientTest.php | New test suite for UpsunClient class testing initialization of all task objects and client configuration |
| tests/Core/OAuthProviderTest.php | New test suite for OAuthProvider class covering token exchange, authorization, and error handling scenarios |
| tests/Core/Tasks/*.php | Updated namespace declarations from Upsun\Tests\Core to Upsun\Tests\Core\Tasks and reorganized imports |
| phpunit.xml | Removed coverage logging configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.