Add OpenTelemetry #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR integrates OpenTelemetry distributed tracing into the Upsun MCP Server, providing observability for request flows, performance metrics, and debugging capabilities. The implementation includes configurable sampling rates, multiple exporters (console, OTLP), automatic instrumentation, and environment-based configuration.
Key Changes
- Added OpenTelemetry SDK with configurable tracing infrastructure supporting console and OTLP exporters
- Implemented automatic span wrapping for all MCP tool handlers via
ToolWrapperutility class - Created centralized configuration module with environment variable parsing and validation
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| upsun-mcp/package.json | Added OpenTelemetry dependencies (api, sdk-node, exporters, auto-instrumentations) |
| upsun-mcp/tsconfig.json | Added Node.js types configuration |
| upsun-mcp/src/core/config.ts | New configuration module centralizing OpenTelemetry and app settings |
| upsun-mcp/src/core/telemetry.ts | New telemetry module implementing OpenTelemetry initialization and span utilities |
| upsun-mcp/src/core/helper.ts | Added ToolWrapper class for automatic tracing of tool handlers |
| upsun-mcp/src/index.ts | Integrated telemetry initialization and graceful shutdown handlers |
| upsun-mcp/src/mcpUpsun.ts | Added tracing to connection methods with span attributes and events |
| upsun-mcp/src/core/gateway.ts | Added tracing to server lifecycle methods |
| upsun-mcp/src/command/*.ts | Wrapped all tool handlers with ToolWrapper.trace for automatic observability |
| upsun-mcp/test/core/*.test.ts | Added comprehensive test coverage for telemetry and configuration modules |
| upsun-mcp/.env.example | Added OpenTelemetry environment variable examples and documentation |
| upsun-mcp/OPENTELEMETRY.md | Added comprehensive configuration guide for OpenTelemetry setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Coverage after merging otel into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage after merging otel into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 28 out of 29 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Coverage after merging otel into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 28 out of 29 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Coverage after merging otel into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.