Support .NET dependencies #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fefa5f6 to
b69c0dc
Compare
b69c0dc to
7f40287
Compare
0cb58d3 to
fc8ab21
Compare
spk
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for .NET projects by introducing a new dotnet dependency manager, updating rules, tests, and documentation to detect Blazor and ASP.NET Core frameworks.
- Implemented
dotnetManagerto parse.csprojandpackages.lock.jsonfiles - Registered the new
.NETmanager and added unit tests for various version scenarios - Extended rule configurations and test data to detect Blazor WebAssembly, Blazor Server, and ASP.NET Core
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/dep/dotnet.go | New .NET manager implementation |
| pkg/dep/dotnet_test.go | Tests covering .NET manager behavior |
| pkg/dep/dep.go | Added dotnet to manager types and registration |
| pkg/rules/testdata/mock-blazor/ | Test assets for Blazor project (.csproj and packages.lock.json) |
| pkg/rules/analyze_testfs_test.go | Extended test cases to include Blazor frameworks and msbuild |
| docs/functions.md | Documented depExists/depVersion for dotnet |
| config/frameworks.yml | Added rules for Blazor WebAssembly, Blazor Server, and ASP.NET Core |
| expr.cache | Updated expression cache to include dotnet functions |
Comments suppressed due to low confidence (3)
config/frameworks.yml:614
- The group order for
blazor-wasmis[dotnet, blazor], but the test expects[]string{"blazor", "dotnet"}. Swap the order to match the test.
group: [dotnet, blazor]
pkg/rules/analyze_testfs_test.go:126
- Add a test case for the
blazor-serverrule inTestAnalyze_TestFS_ActualRulesto cover server-side Blazor detection.
{Ruleset: "frameworks", Path: "blazor-app", Result: "blazor-wasm", Rules: []string{"blazor-wasm"},
docs/functions.md:14
- [nitpick] Use proper nested list syntax in Markdown (e.g., indent with two spaces) so that parameter bullets under
depExistsanddepVersionrender correctly.
- `fs`: The filesystem, representing each directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.