Add support for Meteor #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4434004 to
7a5b626
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds Meteor.js support by parsing .meteor/packages and .meteor/versions, detecting the Meteor framework and its version, and updating tests and configs accordingly.
- Introduces
parseMeteorDepsand wires it intojsManager.parse - Updates filesystem and digest tests to include Meteor scenarios
- Adjusts
package_managers.ymlandframeworks.ymlfor Meteor detection
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/rules/analyze_testfs_test.go | Added Meteor entries to the test filesystem and expected reports |
| pkg/files/digest_test.go | Added Meteor to digest test cases |
| pkg/dep/testdata/js_meteor/* | New fixtures for .meteor/packages and .meteor/versions |
| pkg/dep/js_meteor_test.go | New unit tests for Meteor dependency parsing |
| pkg/dep/js.go | Refactored JS manager parsing logic; added Meteor support |
| config/package_managers.yml | Registered Meteor as a package manager |
| config/frameworks.yml | Registered Meteor.js as a framework |
| expr.cache | Updated expression cache for Meteor detection |
Comments suppressed due to low confidence (1)
pkg/dep/js.go:3
- The type
pnpmLockYAMLreferencesyaml.Nodebut theyamlpackage is not imported. Addgopkg.in/yaml.v3(or equivalent) to the imports to avoid compilation errors.
import (
d60c9b1 to
26428c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for parsing
.meteor/packagesand.meteor/versions, as well as detecting the Meteor.js framework reliably and reporting its version. It adds appropriate tests, and it also refactors thejs.goparse() function a little for readability.