Add support for SBT #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds support for parsing SBT (build.sbt) files for Java projects alongside existing Gradle and Maven support.
- Introduces
parseBuildSBTinjava.goand integrates it into the manager initialization. - Adds
TestSBTinjava_test.gowith embedded test data and a samplebuild_.sbt. - Updates detection rules in
config/package_managers.yml,config/frameworks.yml, and the expression cache to recognize SBT and Play projects.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/dep/java.go | Added parseBuildSBT and hooked it into parse(). |
| pkg/dep/java_test.go | Embedded SBT test data and added TestSBT. |
| pkg/dep/testdata/java_sbt/build_.sbt | Sample SBT build file for tests. |
| config/package_managers.yml | Added detection rule for SBT manager. |
| config/frameworks.yml | Added Play framework detection via Typesafe Play. |
| expr.cache | Updated cached patterns to include build.sbt. |
Comments suppressed due to low confidence (2)
config/frameworks.yml:611
- [nitpick] The
groupfield here is a list, while inconfig/package_managers.ymlthegroupfor SBT is a string. For consistency and to avoid confusion, consider using the same type (e.g., always a list) across configurations.
group: [java]
pkg/dep/testdata/java_sbt/build_.sbt:1
- The test data file is named
build_.sbtbut the code under test looks forbuild.sbt. Consider renaming the file tobuild.sbtto align with the expected filename and reduce confusion.
name := "play-sbt-example"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.