Respect the user's global gitignore file #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcdawkins
commented
Aug 17, 2025
File reading operations should be able to include git-ignored files when explicitly specified. Global gitignore patterns belong in the analysis phase, not the file reading phase. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
The collectDirectories function was missing global gitignore support that should be applied during analysis phase. This ensures the user's global gitignore file is respected when collecting directories to analyze. Also adds test coverage for globally gitignored directories using a real filesystem with a temporary HOME directory. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR enables whatsun to respect patterns defined in the user's global gitignore file when analyzing repositories. The implementation adds global gitignore support to both file tree generation and repository analysis operations.
- Added global gitignore detection logic that checks ~/.gitignore first, then falls back to git config core.excludesFile
- Integrated global gitignore patterns into file tree generation and directory analysis workflows
- Added comprehensive test coverage for global gitignore functionality across different scenarios
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
internal/fsgitignore/gitignore.go |
Core implementation of global gitignore detection and pattern parsing |
internal/fsgitignore/gitignore_test.go |
Comprehensive tests for global gitignore functionality |
pkg/files/tree.go |
Integration of global gitignore patterns into file tree generation |
pkg/rules/analyze.go |
Integration of global gitignore patterns into repository analysis |
pkg/rules/analyze_osfs_test.go |
Test verifying global gitignore works with real filesystem operations |
pkg/rules/analyze_testfs_test.go |
Minor whitespace addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By Claude:
This change enables whatsun to respect patterns in the user's global gitignore file when analyzing repositories and generating file trees.
Changes
whatsun digestandwhatsun analyze)Behavior
When analyzing a repository, whatsun will now automatically exclude files matching patterns from:
This improves the user experience by honoring their personal ignore preferences across all repositories, making the output more relevant and focused.