Add insights enablement check and hide InsightsCard when disabled #25
+40
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add checkInsightsEnabled() API method to check if insights are enabled for a service
- Check insights status on component mount before fetching data
- Hide entire InsightsCard component when insights are not enabled
- Update refresh and time range handlers to respect insights status
- Uses Fastly API endpoint: /enabled-products/v1/log_explorer_insights/services/{service_id}
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds insights enablement checks to prevent fetching insights data and displaying the InsightsCard component when insights are not enabled for a service.
Key Changes
- Added
checkInsightsEnabled()method to ProjectAPIService to verify insights availability via Fastly API - Implemented insights status checking on component mount before data fetching
- Conditionally rendered InsightsCard component based on insights enablement status
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/project/project.service.ts | Added API method to check if insights are enabled for a service |
| src/components/project/InsightsCard.vue | Added insights enablement check and conditional rendering of the card component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code