Remove upstream zone summary output from VTS status #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove "# Upstream Zones:" section from status output - Remove individual server summary lines (e.g., "backend: 1 servers, 1 total requests") - Remove detailed server statistics (e.g., "127.0.0.1:8080: 1 req, 0ms avg") - Remove "# Total Upstream Zones: N" counter - Update all test assertions to remove expectations for summary format - Keep Prometheus metrics intact for programmatic access The VTS status now only shows: 1. Basic module information (version, status, hostname) 2. Prometheus metrics for all upstream statistics This simplifies the output format and focuses on machine-readable metrics rather than human-readable summaries. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove extra blank lines for consistent code formatting. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove remaining assertions expecting upstream zone summary format - Fix mutex poisoning errors by handling PoisonError gracefully - Update all test files to use poison-safe mutex operations - Replace format-specific checks with Prometheus metrics assertions Changes: - Replace `.unwrap()` with proper poison handling for GLOBAL_VTS_TEST_MUTEX - Use match expressions to handle both Ok and Err(PoisonError) cases for VTS_MANAGER - Remove assertions checking for "# Total Upstream Zones:" format - Remove assertions checking for "Xms avg" summary format - Replace with nginx_vts_upstream_response_seconds metric checks All 34 tests now pass successfully. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes human-readable upstream zone summaries from the VTS status output while preserving Prometheus metrics for programmatic access. The changes simplify the status endpoint output by eliminating redundant summary information.
Key changes:
- Remove upstream zone summary section generation from status output
- Update error handling for poisoned mutex locks throughout test files
- Remove test assertions that checked for human-readable summary format
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| testing.sh | New test script with shell path error |
| test_log_phase_handler.rs | Updates mutex handling and removes summary format assertions |
| test_issue3_resolution.rs | Updates mutex handling and removes upstream zone summary checks |
| test_issue3_integrated_flow.rs | Updates mutex handling and removes summary format expectations |
| test_issue2_resolution.rs | Updates mutex handling and removes summary assertions |
| test_issue1_resolution.rs | Updates mutex handling and removes backend summary checks |
| src/lib.rs | Removes upstream zone summary generation code and updates integration tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
generate_vts_status_content()Impact
The VTS status endpoint now outputs a cleaner format focused on:
This simplifies the output and removes redundant human-readable summaries while preserving all statistical data in Prometheus format.
🤖 Generated with Claude Code