cleanup: remove unused functions from stats.rs #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused init_shared_memory() method from VtsStatsManager - Remove duplicate vts_init_shm_zone() function (active version remains in lib.rs) - Preserve essential nginx CABI integration functions - Maintain all core VTS functionality and shared memory handling The removed functions were: - init_shared_memory: Never called from anywhere in the codebase - vts_init_shm_zone: Duplicate implementation, lib.rs version is actively used 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add --test-threads=1 to CI test execution to prevent race conditions - Re-enable test_vts_stats_persistence test after fixing isolation issues - Ensures consistent test behavior across different environments 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replace global state clearing with complete VtsStatsManager reset per test - Add unique test identifiers to prevent cross-test interference - Remove --test-threads=1 workaround as race conditions are now properly fixed - Ensure deterministic test behavior without relying on execution order This addresses the root cause of CI flaky tests by ensuring each test has completely isolated state rather than just masking the symptoms. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Apply standard Rust formatting to resolve CI checks - Improve code readability with consistent formatting 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
src/stats.rsto clean up the codebaseFunctions Removed
🗑️
init_shared_memory()- Unused MethodVtsStatsManager::init_shared_memory()🗑️
vts_init_shm_zone()- Duplicate Functionsrc/stats.rs:263src/lib.rs:1193lib.rsversion continues to handle shared memory zone initializationFunctions Preserved
✅
ngx_http_set_vts_zone()- KEPTsrc/lib.rs:799vts_zone main 10m;configuration✅
vts_init_shm_zone()- KEPTsrc/lib.rs:1193Verification
cargo build --releasepassesImpact
This cleanup removes 31 lines of unused code while:
The codebase is now leaner without any loss of functionality.
🤖 Generated with Claude Code