Dont embed extensions; Add inet extension #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1208fb0 to
5a2fc30
Compare
kaidaguerre
requested changes
Jan 2, 2025
internal/cmdconfig/cmd_hooks.go
Outdated
| } | ||
|
|
||
| // now env vars have been processed, set the default filepaths.PipesInstallDir | ||
| filepaths.PipesInstallDir, err = files.Tildefy("~/.pipes") |
Contributor
There was a problem hiding this comment.
I think this should be done from SetAppSpecificConstants
| } | ||
|
|
||
| func Test_buildViewQuery(t *testing.T) { | ||
| filepaths.PipesInstallDir, _ = files.Tildefy("~/.pipes") |
Contributor
There was a problem hiding this comment.
this should call SetAppSpecificConstants
eaa1a43 to
a7d3195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.