Cleanup old unused db files in data dir. Closes #143 #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidaguerre
requested changes
Jan 16, 2025
cmd/connect.go
Outdated
| // cleanup the old db files if not in use | ||
| err := cleanupOldDbFiles() | ||
| if err != nil { | ||
| log.Printf("[INFO] Failed to cleanup old db files: %v", err) |
Contributor
There was a problem hiding this comment.
same logging exists inside the function
| log.Printf("[INFO] Cleaning up old db files in %s\n", baseDir) | ||
| cutoffTime := time.Now().Add(-constants.DbFileMaxAge) // Files older than 1 day | ||
|
|
||
| err := filepath.Walk(baseDir, func(path string, info os.FileInfo, err error) error { |
Contributor
There was a problem hiding this comment.
are we walking so we get all workdspace dirs? In whiuch case put this in a comment - mention where the root dir is you are walking from, the expectyyed file layout and the target files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.