这是indexloc提供的服务，不要输入任何密码
Skip to content

Exclude rowid #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

Exclude rowid #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/database/compaction_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func getTimeRangesToReorder(ctx context.Context, db *DuckDb, pk *partitionKey, r
if reindex {
rm, err := newReorderMetadata(ctx, db, pk)
if err != nil {
return nil, fmt.Errorf("failed to retiever stats for partition key: %w", err)
return nil, fmt.Errorf("failed to retrieve stats for partition key: %w", err)
}

// make a single time range
Expand Down Expand Up @@ -52,7 +52,7 @@ func getTimeRangesToReorder(ctx context.Context, db *DuckDb, pk *partitionKey, r
// get stats for the partition key
rm, err := newReorderMetadata(ctx, db, pk)
if err != nil {
return nil, fmt.Errorf("failed to retiever stats for partition key: %w", err)
return nil, fmt.Errorf("failed to retrieve stats for partition key: %w", err)
}
rm.unorderedRanges = unorderedRanges
return rm, nil
Expand Down
5 changes: 5 additions & 0 deletions internal/database/tables.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ func GetLegacyTableViewSchema(ctx context.Context, viewName string, db *DuckDb)
return nil, fmt.Errorf("failed to scan column schema: %w", err)
}

// NOTE: legacy tailpipe views may include `rowid` which we must exclude from the schema as this is a DuckDb system column
// that is automatically added to every table
if columnName == "rowid" {
continue
}
col := buildColumnSchema(columnName, columnType)
ts.Columns = append(ts.Columns, col)
}
Expand Down