这是indexloc提供的服务，不要输入任何密码
Skip to content

Install prod duckdb extension. Closes #476 #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
Merged

Install prod duckdb extension. Closes #476 #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,5 @@ func setExitCodeForQueryError(err error) {
return
}

// TODO #errors - assign exit codes https://github.com/turbot/tailpipe/issues/496
exitCode = 1
}
1 change: 0 additions & 1 deletion internal/cmdconfig/cmd_hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ func preRunHook(cmd *cobra.Command, args []string) error {
ew := initGlobalConfig(ctx)
// display any warnings
ew.ShowWarnings()
// TODO #errors sort exit code https://github.com/turbot/tailpipe/issues/496
// check for error
error_helpers.FailOnError(ew.Error)

Expand Down
5 changes: 1 addition & 4 deletions internal/database/duck_db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,10 +285,7 @@ func GetDucklakeInitCommands(readonly bool) []SqlCommand {

commands := []SqlCommand{
{Description: "install sqlite extension", Command: "install sqlite"},
// TODO #DL change to using prod extension when stable
// https://github.com/turbot/tailpipe/issues/476
// _, err = db.Exec("install ducklake;")
{Description: "install ducklake extension", Command: "force install ducklake from core_nightly"},
{Description: "install ducklake extension", Command: "install ducklake;"},
{Description: "attach to ducklake database", Command: attachQuery},
}
return commands
Expand Down
3 changes: 1 addition & 2 deletions internal/parse/load_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,6 @@ func TestParseTailpipeConfig(t *testing.T) {
want *config.TailpipeConfig
wantErr bool
}{
// TODO #testing add more test cases https://github.com/turbot/tailpipe/issues/506
{
name: "static tables",
args: args{
Expand Down Expand Up @@ -868,4 +867,4 @@ func TestParseTailpipeConfig(t *testing.T) {

})
}
}
}
1 change: 0 additions & 1 deletion internal/plugin/plugin_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,6 @@ func loadPluginVersionFile(ctx context.Context) (*versionfile.PluginVersionFile,
return nil, err
}

// TODO CHECK THIS https://github.com/turbot/tailpipe/issues/507
// add any "local" plugins (i.e. plugins installed under the 'local' folder) into the version file
ew := pluginVersions.AddLocalPlugins(ctx)
if ew.Error != nil {
Expand Down