refactor: use React.JSX rather than global JSX
#93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great improvement. Thanks! |
Valerioageno
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context & Description
Close #84.
I remove all the usage of global
JSXI was able to find and replaced them with the one included insideReact.Note
I used typed named imports for it unless there there was already a
import * as React from 'react',in that case I used
React.JSXinstead of adding another import.Additional related changes
<></>) withnull@typescript-eslint/no-deprecatedrule which can report when using@deprecateditemsWhile working on this I got a few ideas about some improvements to repository maintenance and DX.
I'll open separate issue to discuss them later this week.