这是indexloc提供的服务，不要输入任何密码
Skip to content

feat: add form_data method into request #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 3, 2025
Merged

feat: add form_data method into request #651

merged 12 commits into from
Apr 3, 2025

Conversation

kulapoo
Copy link
Contributor

@kulapoo kulapoo commented Mar 20, 2025

Checklist

Related issue

Fixes 635

Overview

This update lets users easily extract form data from incoming requests

demo

2025-03-20-21.02.51.693354622.mp4

@kulapoo kulapoo marked this pull request as ready for review March 20, 2025 21:20
@kulapoo kulapoo requested a review from Valerioageno as a code owner March 20, 2025 21:20
@github-actions github-actions bot added the rust Requires rust knowledge label Mar 20, 2025
@kulapoo
Copy link
Contributor Author

kulapoo commented Mar 21, 2025

I'll take care of those failing.. Also I might still have to update the docs. Will get back to this later once Im available.

@kulapoo kulapoo changed the title feat(crates/tuono_lib) : add form_data method into request feat: add form_data method into request Mar 21, 2025
@kulapoo kulapoo mentioned this pull request Mar 21, 2025
Merged
@kulapoo kulapoo removed their assignment Mar 21, 2025
@kulapoo
Copy link
Contributor Author

kulapoo commented Mar 22, 2025

let me know what else needed here to change, although I have some suggestions related to this in the future but I might create separate feature issue for it.

Valerioageno
Valerioageno requested changes Mar 23, 2025
View reviewed changes
Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Overall looks good but I left few comments. I'm available for discussing them.

I'd ask you also to create a test case in the integration tests/.

I'm all ears also for the suggestions you are talking above :)

@Valerioageno Valerioageno self-assigned this Mar 23, 2025
@Valerioageno
Copy link
Member

PS I'm assigning this PR to you just for better visibility

@Valerioageno Valerioageno assigned kulapoo and unassigned Valerioageno Mar 23, 2025
@kulapoo
Copy link
Contributor Author

kulapoo commented Mar 25, 2025

PS I'm assigning this PR to you just for better visibility

alright will check this. Thanks for the review

@Valerioageno Valerioageno added the enhancement New feature or request label Mar 25, 2025
@kulapoo kulapoo marked this pull request as draft March 29, 2025 00:00
@Valerioageno
Copy link
Member

Valerioageno commented Mar 29, 2025 •
edited
Loading

Hey @kulapoo, please merge your PR with the main branch. I just update the rust edition of the whole repository.

Also I fixed the post() method. There might be some conflicts but I reused part of your PR so you shouldn't find many conflicts. Sorry about that

@kulapoo
Copy link
Contributor Author

kulapoo commented Mar 29, 2025 •
edited
Loading

Hey @kulapoo, please merge your PR with the main branch. I just update the rust edition of the whole repository.

Also I fixed the post() method. There might be some conflicts but I reused part of your PR so you shouldn't find many conflicts. Sorry about that

ahh alribght,,

@kulapoo kulapoo marked this pull request as ready for review March 31, 2025 04:07
@kulapoo kulapoo requested a review from Valerioageno March 31, 2025 04:07
Valerioageno
Valerioageno reviewed Mar 31, 2025
View reviewed changes
@kulapoo kulapoo requested a review from Valerioageno April 1, 2025 12:18
Valerioageno
Valerioageno reviewed Apr 3, 2025
View reviewed changes
Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left few comments. LGTM

@kulapoo kulapoo requested a review from Valerioageno April 3, 2025 14:49
Valerioageno
Valerioageno approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Valerioageno
Copy link
Member

Thanks, @kulapoo, for your contribution

@Valerioageno Valerioageno merged commit 3334bdd into tuono-labs:main Apr 3, 2025
29 checks passed
@chenrui333 chenrui333 mentioned this pull request Apr 4, 2025
Closed
@kulapoo kulapoo mentioned this pull request May 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valerioageno Valerioageno Valerioageno approved these changes

Assignees

@kulapoo kulapoo

Labels
enhancement New feature or request rust Requires rust knowledge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request]: Create a form_data() method for the Request struct
2 participants
@kulapoo @Valerioageno