feat: remove global.css import to enable global CSS file customizations
#650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
global.css import to enable global CSS file customizations
marcalexiei
reviewed
Mar 19, 2025
There was a problem hiding this comment.
I added an empty line between the CSS import and the other imports, as the CSS import uses a relative path and has side effects and to be consistent with the rest of the repository.
I checked the documentation and it looks like that this change doesn't require any update on that end, so once the import format is fixed the PR can be merged.
Co-authored-by: Marco Pasqualetti <24919330+marcalexiei@users.noreply.github.com>
marcalexiei
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Related issue
Fixes None
Overview
With this change we remove the
global.cssfile injection allowing users to create their own CSS setup/filename.