这是indexloc提供的服务,不要输入任何密码
Skip to content

refactor(examples): uniform tsconfig.json files #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

marcalexiei
Copy link
Collaborator

@marcalexiei marcalexiei commented Feb 22, 2025

Checklist

Related issue

Followup of #584 (comment)

Overview

All tsconfig examples files follow the structure provided in the typescript tsconfig reference.


Resolved

Additional consideration:
We might consider to create a package with the default tuono typescript config.
Something like @tuono/ts-config or tuono-ts-config

If you agree, let me know and I'll create a new task so we can discuss this further in the future.

@marcalexiei marcalexiei self-assigned this Feb 22, 2025
@marcalexiei
Copy link
Collaborator Author

Waiting for #584 to be merged (the linked PR add types property to each examples tsconfig)

@Valerioageno

This comment was marked as resolved.

@marcalexiei

This comment was marked as resolved.

@marcalexiei marcalexiei force-pushed the examples-tsc-config-consistency branch from 71d862d to e036686 Compare February 23, 2025 14:04
@marcalexiei marcalexiei marked this pull request as ready for review February 23, 2025 14:11
Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalexiei marcalexiei merged commit 06612f0 into main Feb 23, 2025
20 checks passed
@marcalexiei marcalexiei deleted the examples-tsc-config-consistency branch February 23, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants