这是indexloc提供的服务,不要输入任何密码
Skip to content

feat: update axum to v0.8.1 #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2025
Merged

feat: update axum to v0.8.1 #595

merged 3 commits into from
Feb 26, 2025

Conversation

Valerioageno
Copy link
Member

@Valerioageno Valerioageno commented Feb 23, 2025

Checklist

Related issue

Fixes None

Overview

Supersedes #495

@Valerioageno Valerioageno self-assigned this Feb 23, 2025
@github-actions github-actions bot added the rust Requires rust knowledge label Feb 23, 2025
@Valerioageno Valerioageno requested a review from jacobhq February 24, 2025 18:13
@Valerioageno Valerioageno marked this pull request as ready for review February 24, 2025 18:13
Copy link
Contributor

@jacobhq jacobhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

One thing though - regex is bad for performance and can be hard to read. Since we are matching simple cases it is faster to keep using .replace().

@Valerioageno Valerioageno merged commit caf1a58 into main Feb 26, 2025
20 checks passed
@Valerioageno Valerioageno deleted the update-axum-to-latest branch February 26, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Requires rust knowledge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants