feat: add origin config option
#582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d16b985 to
d916ae2
Compare
d916ae2 to
688ed31
Compare
This commit adds the `origin` as an optional configuration parameter that can be set in the same way as `host` and `port`. This closes tuono-labs#232 and solves use-cases such as being able to develop on localhost with HTTPS with an origin name such as `https://tuono.localhost`, where HTTPS is required for testing certain web features (relating to e.g. storage or web workers). Prior to this commit this will not work as the Vite tools will attempt to load resources from e.g. `http://localhost:3000` and be blocked by the browser for attempting to load HTTP resources from an HTTPS web page.
688ed31 to
0e61e13
Compare
origin config parameterorigin config option
|
@pveierland were you able to make it working on your end? I remember we had a thread on discord about a broken usage with it |
|
Yes, this PR has solved my issues with use of HTTPS during development. There may be other possible improvements to make later, however this PR alone should make normal use-cases work. |
marcalexiei
reviewed
Feb 23, 2025
1 task
marcalexiei
approved these changes
Feb 27, 2025
Valerioageno
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Related issue
Fixes #232
Overview
This commit adds the
originas an optional configuration parameter that can be set in the same way ashostandport.This closes #232 and solves use-cases such as being able to develop on localhost with HTTPS with an origin name such as
https://tuono.localhost, where HTTPS is required for testing certain web features (relating to e.g. storage or web workers).Prior to this commit this will not work as the Vite tools will attempt to load resources from e.g.
http://localhost:3000and be blocked by the browser for attempting to load HTTP resources from an HTTPS web page.