这是indexloc提供的服务，不要输入任何密码
Skip to content

feat(crates/tuono): add --head flag to download most recent template #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 25, 2025
Merged

feat(crates/tuono): add --head flag to download most recent template #408

merged 14 commits into from
Jan 25, 2025

Conversation

jacobhq
Copy link
Contributor

@jacobhq jacobhq commented Jan 22, 2025

Context & Description

Fixes #262, and supersedes #292

@github-actions github-actions bot added the rust Requires rust knowledge label Jan 22, 2025
@jacobhq
Copy link
Contributor Author

jacobhq commented Jan 23, 2025

This PR will be ready to merge after #262 (comment) is addressed.

@jacobhq jacobhq marked this pull request as ready for review January 23, 2025 20:55
@jacobhq jacobhq requested a review from Valerioageno as a code owner January 23, 2025 20:55
@marcalexiei marcalexiei changed the title feat(crates/tuono): add flag to download latest template feat(crates/tuono): add --head flag to download most recent template Jan 24, 2025
Valerioageno
Valerioageno reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left just a couple of comments :)

@jacobhq jacobhq mentioned this pull request Jan 24, 2025
Closed
2 tasks
@jacobhq
Copy link
Contributor Author

jacobhq commented Jan 24, 2025

Alright, this is ready to merge :)

Valerioageno
Valerioageno requested changes Jan 24, 2025
View reviewed changes
Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the tests for generate_raw_content_url. Have you pushed them?

jacobhq and others added 2 commits January 24, 2025 20:36
@jacobhq @Valerioageno
implement suggestions
acbbcc3 
Co-authored-by: Valerio Ageno <51341197+Valerioageno@users.noreply.github.com>
@jacobhq
add unit tests
385141d
@jacobhq
Copy link
Contributor Author

jacobhq commented Jan 24, 2025

Here they are. Since these are unit tests, I put them in the bottom of the scaffold_project.rs file. Was that the right call?

@jacobhq jacobhq requested a review from Valerioageno January 25, 2025 08:26
Valerioageno
Valerioageno approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@Valerioageno Valerioageno merged commit d5cc659 into tuono-labs:main Jan 25, 2025
16 checks passed
@jacobhq jacobhq deleted the jm-add-latest branch January 25, 2025 13:46
@jacobhq jacobhq restored the jm-add-latest branch February 22, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robert-maker1994 Robert-maker1994 Robert-maker1994 left review comments

@Valerioageno Valerioageno Valerioageno approved these changes

Assignees

@jacobhq jacobhq

Labels
rust Requires rust knowledge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --latest flag to tuono new to download latest templates
3 participants
@jacobhq @Valerioageno @Robert-maker1994