feat: update rendering from renderToString to renderToReadableStream
#233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renderToString to renderToReadableStream
316ab0a to
f66ab97
Compare
marcalexiei
reviewed
Dec 18, 2024
marcalexiei
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context & Description
This PR turns the kinda "deprecated"
renderToStringto the newrenderToReadableStreamsolving the last issue related to #216.For this iteration, we just wait for the whole stream, and then we pass it to the rust server. In a next iteration, we will need to pass every stream's chunk to rust to start streaming the response to the client. This will leverage the async server side resources loading, enhancing the user experience.