fix: handle hyphen in route #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
crates/tuono/src/route.rs
Outdated
| @@ -30,7 +30,7 @@ impl AxumInfo { | |||
| let module_import = module | |||
| .as_str() | |||
| .to_string() | |||
| .replace('/', "_") | |||
| .replace(['/', '-'], "_") | |||
There was a problem hiding this comment.
We should avoid this. I think this means that: route/subroute and route-subroute would get mapped with the same value. I'd follow the same pattern as the .: _hyphen_
crates/tuono/src/route.rs
Outdated
| @@ -186,6 +186,19 @@ mod tests { | |||
| assert_eq!(dyn_info.module_import, "dyn_posts"); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn should_handle_hyphen() { | |||
There was a problem hiding this comment.
Thanks for the test. Right now we have already a test that checks for the correct route parsing. in src/app.rs. The test name is should_collect_routes. Could you please just add the map there? I agree that the test should better apply for the route.rs file but I'd keep all together for now
|
Thanks for spotting this! |
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
Valerioageno
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context & Description
I got this exception when trying to use a hyphen in route. e.g.
assuming the fix it to replacing
-to_that makes compiler happy.