[FEATURE] Add serialization/deserialization support for list of tuples, optional list, optional tuple #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
reviewed
Apr 21, 2022
LeonhardFS
requested changes
Apr 21, 2022
Contributor
LeonhardFS
left a comment
There was a problem hiding this comment.
Great work here! Couple minor things, mostly doc. Else, I think there's one Python ref counting issue, else all good.
LeonhardFS
reviewed
May 18, 2022
| */ | ||
| PyObject *createPyObjectFromMemory(const uint8_t *ptr, const python::Type &row_type, const uint8_t *bitmap = nullptr, int index = 0); | ||
| PyObject * | ||
| createPyObjectFromMemory(const uint8_t *ptr, const python::Type &row_type, int64_t capacity, |
Contributor
There was a problem hiding this comment.
why int64_t? why not size_t?
LeonhardFS
reviewed
May 18, 2022
| * @param objectType current object type that contains optional value | ||
| * @param ptr memory location to where the start of bitmap | ||
| * @param numElements number of elements in objectType for which bitmap is needed | ||
| * @return |
LeonhardFS
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add serialization/deserialization support for list of tuples, list of lists, optional list, and optional tuple