-
Notifications
You must be signed in to change notification settings - Fork 47
[FEATURE] Add html preview of dataset #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KorlaMarch
wants to merge
62
commits into
tuplex:master
Choose a base branch
from
KorlaMarch:jupyter_html
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11d5441 to
a577dcb
Compare
a8c3b2e to
89cee2e
Compare
LeonhardFS
reviewed
Feb 25, 2022
LeonhardFS
reviewed
Feb 25, 2022
LeonhardFS
reviewed
Feb 25, 2022
LeonhardFS
reviewed
Feb 25, 2022
LeonhardFS
reviewed
Feb 25, 2022
LeonhardFS
reviewed
Mar 9, 2022
LeonhardFS
reviewed
Mar 9, 2022
LeonhardFS
reviewed
Mar 9, 2022
LeonhardFS
reviewed
Mar 9, 2022
LeonhardFS
reviewed
Mar 9, 2022
LeonhardFS
reviewed
Mar 9, 2022
LeonhardFS
reviewed
Mar 9, 2022
LeonhardFS
reviewed
Mar 9, 2022
LeonhardFS
reviewed
Mar 9, 2022
LeonhardFS
reviewed
Mar 9, 2022
LeonhardFS
reviewed
Mar 9, 2022
LeonhardFS
reviewed
Mar 9, 2022
LeonhardFS
reviewed
Mar 9, 2022
a072e40 to
6f528f8
Compare
LeonhardFS
reviewed
May 13, 2022
LeonhardFS
reviewed
May 13, 2022
Collaborator
Author
|
test is passing now, so this is ready to merge whenever you're ready @LeonhardFS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still work-in-progress. It's not a complete feature yet!
Currently the preview is done by
__html__()function in Dataset.py, which is a pure python implementation using data fromcollect(). The problem is that it is really slow on the large datasetI am in the middle of adding
takeLast()operator to C++ backend, which will speed up the computation (hopefully!).