[BUG FIX] Var Length Mixed Type Tuples #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonhardFS
reviewed
Dec 6, 2021
tuplex/python/src/PythonContext.cc
Outdated
| if (typeStr[j] == 's') { | ||
| auto tupleItem = PyTuple_GetItem(obj, j); | ||
| if (PyUnicode_Check(tupleItem)) { | ||
| requiredBytes += PyUnicode_GET_SIZE(PyTuple_GetItem(obj, j)) + 1; // +1 for '\0' |
Contributor
There was a problem hiding this comment.
don't call PyTuple_GetItem here again, use the one from before and adjust refcount to be correct. https://docs.python.org/3.9/c-api/refcounting.html (check doc for PyTuple as well, maybe toy example to get correct refcount here :) )
LeonhardFS
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where non-conforming rows will crash Tuplex when the majority type is a simple tuple containing var length fields.