[FEATURE] Parallelize support for normal case violations #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[TEST] Added a test
LeonhardFS
reviewed
Dec 14, 2021
LeonhardFS
reviewed
Dec 14, 2021
LeonhardFS
reviewed
Dec 14, 2021
LeonhardFS
reviewed
Jan 20, 2022
LeonhardFS
reviewed
Jan 20, 2022
LeonhardFS
reviewed
Jan 20, 2022
LeonhardFS
reviewed
Jan 20, 2022
LeonhardFS
reviewed
Jan 20, 2022
LeonhardFS
reviewed
Jan 20, 2022
LeonhardFS
reviewed
Jan 20, 2022
| //! an exception while being processed through the pipeline before | ||
| std::vector<PyObject*> _py_objects; //! all python objects who do not adhere to the general case schema ( | ||
| std::unordered_map<std::string, ExceptionInfo> _partitionToExceptionsMap; //! maps normal case partitions to corresponding general case ones | ||
| std::vector<PyObject*> _py_objects; //! all python objects who do not adhere to the general case schema |
Contributor
There was a problem hiding this comment.
they do not need row numbers, right?
LeonhardFS
reviewed
Jan 20, 2022
LeonhardFS
requested changes
Jan 20, 2022
Contributor
LeonhardFS
left a comment
There was a problem hiding this comment.
I think some delete [] for the exception memory is missing
LeonhardFS
reviewed
Jan 22, 2022
| for(int i = _currentNormalPartitionIdx + 1; i < _partitions.size(); ++i) { | ||
| _mergedRowsSink.unlock(); | ||
| _mergedRowsSink.partitions.push_back(_partitions[i]); | ||
| //_mergedPartitions.emplace_back(_normalCasePartitions[i]); |
Contributor
There was a problem hiding this comment.
what's up with this comment? can we remove the line or should be commented back in?
LeonhardFS
reviewed
Jan 22, 2022
tuplex/python/src/PythonContext.cc
Outdated
| if(partition->capacity() < numBytesSerialized + sizeof(double)) { | ||
| assert(_badParallelizeObjects.size() >= prevNumExceptions); | ||
| auto numNewExceptions = _badParallelizeObjects.size() - prevNumExceptions; | ||
| _inputPartitionToPythonObjectsMap[uuidToString(partition->uuid())] = ExceptionInfo(numNewExceptions, 0, 0, 0); |
Contributor
There was a problem hiding this comment.
what's the logic for putting 0, 0, 0 here?
LeonhardFS
approved these changes
Jan 22, 2022
Contributor
LeonhardFS
left a comment
There was a problem hiding this comment.
good to merge once CI finishes/passes.
LeonhardFS
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for parallelize with normal case violations and file input schema violations as well.