[FEATURE] Loop type speculation and auto-unrolling #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonhardFS
reviewed
Nov 4, 2021
LeonhardFS
reviewed
Nov 4, 2021
LeonhardFS
reviewed
Nov 4, 2021
LeonhardFS
reviewed
Nov 4, 2021
LeonhardFS
reviewed
Nov 4, 2021
LeonhardFS
reviewed
Nov 4, 2021
LeonhardFS
reviewed
Nov 4, 2021
LeonhardFS
reviewed
Nov 4, 2021
LeonhardFS
reviewed
Nov 4, 2021
LeonhardFS
reviewed
Nov 4, 2021
LeonhardFS
reviewed
Nov 4, 2021
LeonhardFS
reviewed
Nov 4, 2021
LeonhardFS
reviewed
Nov 4, 2021
LeonhardFS
requested changes
Nov 4, 2021
Contributor
LeonhardFS
left a comment
There was a problem hiding this comment.
Great job here, I really couldn't find much except some documentation things. Let's get these done & everything merged to master :)
Added logic to check and add this CompileError through TypeAnnotatorVisitor and TraceVisitor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type speculation for loops to allow compiling UDFs that contain type change during loop by unrolling the first iteration, if the type change results in type-stability starting from the second iteration.