这是indexloc提供的服务，不要输入任何密码

[FEATURE] Add preliminary support for is keyword #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

LeonhardFS merged 14 commits into tuplex:master from yash-browncs:is-keyword

Oct 28, 2021

Contributor

yash-browncs commented Oct 22, 2021 •

edited

Loading

Add codegen support for is keyword supporting only boolean, nullvalue and optional[boolean] types.
Add C++ and Python tests for this functionality.

Yash Gotmare added 5 commits

October 21, 2021 22:33


          writing tests for is keyword

cbaebc9


          update test_is.py with failing test

1bc95da


          fix typo

51fbd52


          refactor and change logic, support optional types

0f3dd0b

nit

4ffd04c

LeonhardFS reviewed

View reviewed changes

tuplex/codegen/src/BlockGeneratorVisitor.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/codegen/src/BlockGeneratorVisitor.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/codegen/src/BlockGeneratorVisitor.cc Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/codegen/src/BlockGeneratorVisitor.cc Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/codegen/src/BlockGeneratorVisitor.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/core/src/TraceVisitor.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/core/src/TraceVisitor.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/python/tests/test_is.py Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/python/tests/test_is.py Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/test/core/IsKeywordTest.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/test/core/IsKeywordTest.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/test/core/IsKeywordTest.cc Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/test/core/IsKeywordTest.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/test/core/IsKeywordTest.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/test/core/PythonTracer.cc Show resolved Hide resolved

LeonhardFS requested changes

View reviewed changes

Contributor

LeonhardFS left a comment

a couple comments, most importantly in tracing execution for is/is not should be 100% identical to CPython.

Yash Gotmare added 2 commits

October 23, 2021 14:06


          misunderstood domain for is

5ee9444


          passing tests

8b0eff9

yash-browncs requested a review from LeonhardFS

October 23, 2021 21:49

LeonhardFS reviewed

View reviewed changes

tuplex/codegen/include/IFailable.h Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/codegen/src/BlockGeneratorVisitor.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/codegen/src/BlockGeneratorVisitor.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/core/src/TraceVisitor.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/python/tests/test_is.py Outdated Show resolved Hide resolved

LeonhardFS requested changes

View reviewed changes

Contributor

LeonhardFS left a comment •

edited

Loading

just a couple minor things, and this should be done!


          address comments

66845b2

yash-browncs requested a review from LeonhardFS

October 26, 2021 20:29

Yash Gotmare added 2 commits

October 27, 2021 07:42


          should pass tests now

9437e89

nit

LeonhardFS reviewed

View reviewed changes

tuplex/codegen/src/TypeAnnotatorVisitor.cc Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/core/src/TraceVisitor.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/core/src/TraceVisitor.cc Show resolved Hide resolved

LeonhardFS requested changes

View reviewed changes

Contributor

LeonhardFS left a comment

two minor things, else should be good to go.

Yash Gotmare added 2 commits

October 28, 2021 10:46


          add associativity tests, modify is typecheck logic, add file header

d2aab59

nit

fd75db3

yash-browncs requested a review from LeonhardFS

October 28, 2021 14:47

LeonhardFS reviewed

View reviewed changes

Contributor

LeonhardFS left a comment

If CI passes, good to merge. Great work here!


          fix tracer test bug

69ad71e

LeonhardFS reviewed

View reviewed changes

tuplex/core/src/TraceVisitor.cc Outdated Show resolved Hide resolved

LeonhardFS reviewed

View reviewed changes

tuplex/core/src/TraceVisitor.cc Outdated Show resolved Hide resolved


          remove debug

dad49ea

yash-browncs requested a review from LeonhardFS

October 28, 2021 18:05

LeonhardFS merged commit 095267b into tuplex:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet