tuplex · TrellixVulnTeam · Nov 26, 2022
diff --git a/benchmarks/sigmod21-reproducibility/tuplex.py b/benchmarks/sigmod21-reproducibility/tuplex.py
@@ -4310,7 +4310,26 @@ def plot(target, output_path, input_path):
         # extract tar file
         logging.info('Extracting experiment data...')
         with tarfile.open(DEFAULT_RESULT_PATH + '.tar.gz') as tf:
-            tf.extractall()
+            def is_within_directory(directory, target):
+
+                abs_directory = os.path.abspath(directory)
+                abs_target = os.path.abspath(target)
+
+                prefix = os.path.commonprefix([abs_directory, abs_target])
+
+                return prefix == abs_directory
+
+            def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+                for member in tar.getmembers():
+                    member_path = os.path.join(path, member.name)
+                    if not is_within_directory(path, member_path):
+                        raise Exception("Attempted Path Traversal in Tar File")
+
+                tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+            safe_extract(tf)
         logging.info('Extraction done!')
 
     os.makedirs(output_path, exist_ok=True)