这是indexloc提供的服务，不要输入任何密码
Skip to content

[BUG] Remove print of cloudpickle version #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2023
Merged

[BUG] Remove print of cloudpickle version #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03902b6
remove print statements
LeonhardFS Oct 26, 2023
2c402aa
Merge branch 'master' into ls-fix-debug-print
LeonhardFS Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tuplex/adapters/cpython/src/PythonHelpers.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,6 @@ namespace python {
// PyRun_SimpleString("gc.set_debug(gc.DEBUG_LEAK)");
// PyRun_SimpleString("gc.disable()");

PyRun_SimpleString("import pickle");
PyRun_SimpleString("import cloudpickle; print(cloudpickle.__version__)");

// import cloudpickle for serialized functions
PyObject *cloudpickleModule = PyImport_ImportModule("cloudpickle");

Expand Down
5 changes: 1 addition & 4 deletions tuplex/python/tuplex/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,6 @@ def __init__(self, conf=None, name="", **kwargs):
if options['tuplex.webui.enable']:
ensure_webui(options)

# last arg are the options as json string serialized b.c. of boost python problems
logging.debug('Creating C++ context object')

# because webui=False/True is convenient, pass it as well to tuplex options
if 'tuplex.webui' in options.keys():
options['tuplex.webui.enable'] = options['tuplex.webui']
Expand All @@ -201,8 +198,8 @@ def __init__(self, conf=None, name="", **kwargs):
options['tuplex.webui.enable'] = options['webui']
del options['webui']

# last arg are the options as json string serialized b.c. of boost python problems
self._context = _Context(name, runtime_path, json.dumps(options))
logging.debug('C++ object created.')
python_metrics = self._context.getMetrics()
assert python_metrics, 'internal error: metrics object should be valid'
self.metrics = Metrics(python_metrics)
Expand Down